From: Jacob Keller <jacob.keller@gmail.com>
Date: Thu, 25 Feb 2016 18:07:40 GMT
Subject: Re: [PATCH v2] git: submodule honor -c credential.* from command line
Message-ID: <CA+P7+xpTAsmFTAA6LkBeQ=x8EjfmiC=++CGEAZBHXeCpvejqfw@mail.gmail.com>
In-Reply-To: <20160225071159.GA22529@sigill.intra.peff.net>

On Wed, Feb 24, 2016 at 11:11 PM, Jeff King <peff@peff.net> wrote:
> On Thu, Feb 25, 2016 at 02:00:36AM -0500, Jeff King wrote:
>
>> I think something like this would work:
>> [...]
>> but it does not seem to pass with your patch (even after I fixed up the
>> weird "local" thing). I think the problem is that we ask
>> submodule--helper to do the clone, and it uses local_repo_env. So in
>> addition to your patch, you probably need a C version of the same thing
>> which outputs to an argv_array.
>
> Something like this (which passes my test, but I didn't think hard about
> it beyond that):

I am having trouble getting the httpd tests to work.. The error.log
generated contains the following:

[Thu Feb 25 18:01:58.583832 2016] [core:crit] [pid 16376] AH00136:
Server MUST relinquish startup privileges before accepting
connections.  Please ensure mod_unixd or other system security module
is loaded.
AH00016: Configuration Failed

I have httpd 2.4, so I'm not sure exactly what the deal is here for
these tests..

Any suggestions on what causes this?

Thanks,
Jake