From: Jacob Keller <jacob.keller@gmail.com>
Date: Fri, 14 Aug 2015 21:12:20 GMT
Subject: Re: [PATCH v6 3/4] notes: add notes.mergestrategy option to select default strategy
Message-ID: <CA+P7+xpPFO4cJbK=nZMMy8DYAB71xzq=gEaTB5D+_KACZLzaDw@mail.gmail.com>
In-Reply-To: <CAPig+cTjQu2LRuR5cC+VSihVB00k-bjew3eCqA4Ee_tRuDK_=w@mail.gmail.com>

On Fri, Aug 14, 2015 at 2:06 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>     const char *value;
>
>     if (!git_config_get_string_const(key, &value)) {
>         if (parse_notes_strategy(value, strategy))
>             git_die_config(key, "unknown notes merge strategy '%s'", value);
>         return 0;
>     }
>     return 1;
>
> Or, the equivalent, but less indented:
>
>     if (git_config_get_string_const(key, &value))
>         return 1;
>     if (parse_notes_strategy(value, strategy))
>         git_die_config(key, "unknown notes merge strategy '%s'", value);
>     return 0;


I like it. Will do.