From: Jacob Keller <jacob.keller@gmail.com>
Date: Thu, 18 Aug 2016 18:29:23 GMT
Subject: Re: [PATCH v7 2/7] graph: add support for --line-prefix on all graph-aware output
Message-ID: <CA+P7+xpEDy5xqNp=tFGauE7+N2hnaGgzZKr2neM2p6G6kvchWQ@mail.gmail.com>
In-Reply-To: <CAGZ79kZeSwteU84-=GZ0cZDCJUf6=VrGzAiNqC_gx7DgTQX-8Q@mail.gmail.com>

On Thu, Aug 18, 2016 at 10:56 AM, Stefan Beller <sbeller@google.com> wrote:
> On Wed, Aug 17, 2016 at 5:51 PM, Jacob Keller <jacob.e.keller@intel.com> wrote:
>> - if (!graph)
>> + if (!graph) {
>> +         graph_show_line_prefix(default_diffopt);
>>           return;
>> + }
>
>> -       if (graph_is_commit_finished(graph))
>> +       if (graph_is_commit_finished(graph)) {
>> +               graph_show_line_prefix(&graph->revs->diffopt);
>>                 return 0;
>> +       }
>
> This seems to be a reoccurring pattern, i.e. we need to add a lot of
> one off instructions before a return. Is it possible to make the call
> earlier instead
> of just before the returns? (or later for that matter) ?
>

Not sure what you mean by this...? Just move the call up above this? I
think that will work, let me give it a try.

Thanks,
Jake

>
> Thanks,
> Stefan