From: Jacob Keller <jacob.keller@gmail.com>
Date: Wed, 16 May 2018 21:20:22 GMT
Subject: Re: [PATCH v2 1/3] merge: setup `opts` later in `checkout_fast_forward()`
Message-ID: <CA+P7+xpDMz+Drqk0MoC0y1nQgjK_rtqow2rshPotR3EGaOB2bw@mail.gmail.com>
In-Reply-To: <CAGZ79kYBykcbzKxc_FHiL6dt=jkmK2Khe-e5aSxFephe=RsBFA@mail.gmail.com>

On Wed, May 16, 2018 at 9:41 AM, Stefan Beller <sbeller@google.com> wrote:
> + Jonathan Tan for a side discussion on anchoring.
>
> On Wed, May 16, 2018 at 9:30 AM, Martin Ågren <martin.agren@gmail.com> wrote:
>>
>> This patch is best viewed using something like this (note the tab!):
>> --color-moved --anchored="      trees[nr_trees] = parse_tree_indirect"
>
> Heh! Having a "is best viewed" paragraph is the new shiny thing in
> commit messages as 'git log origin/pu --grep "is best viewed"' tells me.
>
> Regarding the anchoring, I wonder if we can improve it by ignoring
> whitespaces or just looking for substrings, or by allowing regexes or ...
>
> Thanks,
> Stefan

I think expanding it to be regexp would be nicest. To be honest, I
already thought it was substring based....

It'd be *really* cool if we had a way for a commit messages (or maybe
notes?) to indicate the anchor so that git show could (optionally)
figure out the anchor automatically. It's been REALLY useful for me
when showing diffs to be able to provide a better idea of what a human
*actually* did vs what the smallest diff was.

Thanks,
Jake