From: Jacob Keller Date: Thu, 05 Apr 2018 23:37:23 GMT Subject: Re: [PATCH v2 2/4] push: colorize errors Message-ID: In-Reply-To: On Thu, Apr 5, 2018 at 3:48 PM, Johannes Schindelin wrote: > From: Ryan Dammrose > > This is an attempt to resolve an issue I experience with people that are > new to Git -- especially colleagues in a team setting -- where they miss > that their push to a remote location failed because the failure and > success both return a block of white text. > > An example is if I push something to a remote repository and then a > colleague attempts to push to the same remote repository and the push > fails because it requires them to pull first, but they don't notice > because a success and failure both return a block of white text. They > then continue about their business, thinking it has been successfully > pushed. > > This patch colorizes the errors and hints (in red and yellow, > respectively) so whenever there is a failure when pushing to a remote > repository that fails, it is more noticeable. > > [jes: fixed a couple bugs, added the color.{advice,push,transport} > settings, refactored to use want_color_stderr().] > > Signed-off-by: Ryan Dammrose ryandammrose@gmail.com > Signed-off-by: Johannes Schindelin > > squash! push: colorize errors > > Stop talking about localized errors Guessing you intended to remove this part after squashing? Didn't see anything else to comment on in the actual code. Thanks, Jake