From: Jacob Keller <jacob.keller@gmail.com>
Date: Tue, 23 Aug 2016 21:06:17 GMT
Subject: Re: [PATCH] format-patch: show 0/1 and 1/1 for singleton patch with cover letter
Message-ID: <CA+P7+xp1ipo1dDT+f4GF76+EY=vGx2kEqOsy0jdgCmzA=Ud1eQ@mail.gmail.com>
In-Reply-To: <xmqq37lvxx5o.fsf@gitster.mtv.corp.google.com>

On Tue, Aug 23, 2016 at 9:33 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jacob Keller <jacob.e.keller@intel.com> writes:
>
>> From: Jacob Keller <jacob.keller@gmail.com>
>>
>> Change the default behavior of git-format-patch to generate numbered
>> sequence of 0/1 and 1/1 when generating both a cover-letter and a single
>> patch. This standardizes the cover letter to have 0/N which helps
>> distinguish the cover letter from the patch itself. Since the behavior
>> is easily changed via configuration as well as the use of -n and -N this
>> should be acceptable default behavior.
>>
>> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
>> ---
>
> This obviously changes the behaviour, but I do not think of a reason
> why this change is a bad idea.
>

Yes. The basic idea is "number all files outputted if we generate more
than 1 file" Since a cover letter is a separate file, we number 0/1
and 1/1.

Thanks,
Jake