From: Jacob Keller Date: Thu, 16 Feb 2017 23:27:02 GMT Subject: Re: [RFCv4 PATCH 00/14] Checkout aware of Submodules! Message-ID: In-Reply-To: On Thu, Feb 16, 2017 at 2:56 PM, Stefan Beller wrote: > On Thu, Feb 16, 2017 at 2:54 PM, Jacob Keller wrote: >> On Thu, Feb 16, 2017 at 2:00 PM, Junio C Hamano wrote: >>> Stefan Beller writes: >>> >>>> Integrate updating the submodules into git checkout,... >>> >>> It was more or less a pleasant read, once I decided to pretend that >>> I were a machine who uses identifiers only to identify locations in >>> the program ;-) IOW, for human consumption, the new names introduced >>> were sometimes quite confusing and went against helping understanding. >>> >> >> Based on my cursory reading, I agree. I had trouble understanding how >> the process worked because the names were somewhat confusing. They >> started to make some sense as I read more. I think v4 had better names >> than v3, but they were still somewhat confusing to me. >> > > Now if only you could tell me what names were better to understand. ;) > I'll reply to the individual patch remarks and hopefully there we find > good names for these functions. > > Thanks, > Stefan I'll try to read it again and see if I think of anything. Thanks, Jake