From: Jacob Keller <jacob.keller@gmail.com>
Date: Thu, 18 Aug 2016 07:37:49 GMT
Subject: Re: [PATCH v7 6/7] submodule: refactor show_submodule_summary with helper function
Message-ID: <CA+P7+xoifLexpG0Me4XuCcxN_XYBVQyTrha_RSO8m-R5LfZUOg@mail.gmail.com>
In-Reply-To: <20160818070023.GA30666@gmail.com>

On Thu, Aug 18, 2016 at 12:00 AM, David Aguilar <davvid@gmail.com> wrote:
>> +void show_submodule_summary(FILE *f, const char *path,
>> +             const char *line_prefix,
>> +             unsigned char one[20], unsigned char two[20],
>> +             unsigned dirty_submodule, const char *meta,
>> +             const char *del, const char *add, const char *reset)
>
>
> ... and here too.
>
> There's an ongoing effort to replace unsigned char sha1[20]
> with struct object_id.  It might make sense to pass "one" and
> "two" as "unsigned char*" instead of hard-coding the SHA1-length
> here.  Alternatively, we could pass in the struct object_id*
> instead.
>
> The [20] in the show_submodule_header() function above is
> pre-existing and not added by this patch, but that function's
> signature is touched by this patch so it might make sense to
> tidy that up while we're in here, possibly as a separate patch.
> --

I'll add a patch to the series that does this inbetween these commits.

Thanks,
Jake