From: Jacob Keller <jacob.keller@gmail.com>
Date: Thu, 22 Jan 2026 20:16:53 GMT
Subject: Re: [PATCH v3] submodule: fetch missing objects from default remote
Message-ID: <CA+P7+xoYA6zhwVeCV6d5yW4ZxOKNLam3r-ayEDHpYpFqWyLduw@mail.gmail.com>
In-Reply-To: <xmqq5x8to53y.fsf@gitster.g>

On Thu, Jan 22, 2026 at 10:49 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Nasser Grainawi <nasser.grainawi@oss.qualcomm.com> writes:
>
> > When be76c21282 (fetch: ensure submodule objects fetched, 2018-12-06)
> > added support for fetching a missing submodule object by id, it
> > hardcoded the remote name as "origin" and deferred anything more
> > complicated for a later patch. Implement the NEEDSWORK item to remove
> > the hardcoded assumption by adding and using a submodule helper subcmd
> > 'get-default-remote'. Fixing this lets 'git fetch --recurse-submodules'
> > succeed when the fetched commit(s) in the superproject trigger a
> > submodule fetch, and that submodule's default remote name is not
> > "origin".
> >
> > Add non-"origin" remote tests to t5526-fetch-submodules.sh and
> > t5572-pull-submodule.sh demonstrating this works as expected and add
> > dedicated tests for get-default-remote.
> >
> > Signed-off-by: Nasser Grainawi <nasser.grainawi@oss.qualcomm.com>
> > Reviewed-by: Jacob Keller <jacob.keller@gmail.com>
> > ---
>
> Thanks.  Jacob, this v3 is not exactly the same as v1 that you
> reviewed (and range-diff relative to v2 does not capture what got
> changed between the version you saw and this version), but I just
> checked that they are "essentially identical" except for the
> proposed log message.  Are you happy with having your Reviewed-by on
> this version?
>

I re-reviewed the patch and everything looks fine to me:

Reviewed-by: Jacob Keller <jacob.keller@gmail.com>