From: Jacob Keller <jacob.keller@gmail.com>
Date: Fri, 19 Feb 2016 07:51:25 GMT
Subject: Re: git submodule should honor "-c credential.helper" command line argument
Message-ID: <CA+P7+xoN+ye38tHiXc=WGenuuF0NVA1R-3nfd5_LNjOF01EJfQ@mail.gmail.com>
In-Reply-To: <20160219074633.GA780@sigill.intra.peff.net>

On Thu, Feb 18, 2016 at 11:46 PM, Jeff King <peff@peff.net> wrote:
> To trigger a credential fetch in actual use, you have to clone over
> http. See the credential tests in t5550, for example.
>

I'll look at these.

>> As for how to whitelist config to share with the submodule I am really
>> not 100% sure, since we just clear GIT_CONFIG_PARAMETERS, and I think
>> we'd need a specialized variant of clear_local_git_env_vars specific
>> to submodule then.
>
> Yeah, you'll have to parse, which is pretty painful. In C, you'd do
> something like:

<snip>

>
> but right now git-submodule.sh is all in shell. You'd probably need a
> special helper from git-submodule--helper, though it might simply make
> sense to put this off until the submodule code is fully ported to C.
>

I think the best approach is probably to put this off since I am not
100% sure how we'd handle environment variables from swapping into
submoduler--helper and out. That seems really finicky and likely to go
away once the full port occurs so I am not sure it's worth it.

> -Peff