From: Chandra Pratap Date: Tue, 25 Jun 2024 14:11:02 GMT Subject: Re: [PATCH 09/11] t-reftable-record: add index tests for reftable_record_is_deletion() Message-ID: In-Reply-To: On Tue, 25 Jun 2024 at 14:49, Karthik Nayak wrote: > > Chandra Pratap writes: > > > reftable_record_is_deletion() is a function defined in > > reftable/record.{c, h} that determines whether a record is of > > type deletion or not. In the current testing setup, this function > > Nit: 'In the current testing setup' holds true for the series, but on a > commit level, this statement needs to be modified with each tackled > type. I'm not quite sure I follow. Could you explain this a bit further?