From: Elia Pinto <gitter.spiros@gmail.com>
Date: Tue, 25 Mar 2014 10:03:42 GMT
Subject: Re: [PATCH 001/144] check-builtins.sh: use the $( ... ) construct for command substitution
Message-ID: <CA+EOSBnzcBA433-HwmnRh4Xefh54NLg8e+bYhx5K8j9j5RvmSQ@mail.gmail.com>
In-Reply-To: <vpqa9ce7k1x.fsf@anie.imag.fr>

2014-03-25 9:35 GMT+01:00 Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>:
> Elia Pinto <gitter.spiros@gmail.com> writes:
>
>> and is supported by POSIX. However,all but the simplest uses become
>
> Missing space after comma.
>
>> complicated quickly. In particular,embedded command substitutions
>
> Ditto.
>
> (neither should block merging, but they would be worth fixing if you
> need a reroll)
>
> Did you do these 144 patches by hand, or did you use a script (e.g. perl
> substitution or so) to do it? If the later, then you should include
> explanations in your commit message.

I had used a toy sed script. No bulletproof.  Then I did a manual review.

I review the patch series, adjust the comment was added, and resend the V2.

Thanks again
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/