From: Elia Pinto Date: Mon, 04 Apr 2016 16:08:38 GMT Subject: Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable Message-ID: In-Reply-To: 2016-04-01 17:35 GMT+02:00 Junio C Hamano : > Elia Pinto writes: > >> Implements the GIT_CURL_DEBUG environment variable to allow a greater >> degree of detail of GIT_CURL_VERBOSE, in particular the complete >> transport header and all the data payload exchanged. >> It might be useful if a particular situation could require a more >> thorough debugging analysis. > > My impression is that using GIT_TRACE_* is the more mainstream > trend, and it may be beneficial to work any new debugging aid like > this one to fit within that mechanism. I thought about it, and I agree with you. The idea could be - Call the variable GIT_TRACE_CURL_DEBUG instead - Add the new GIT_TRACE_CURL_VERBOSE variable, keeping GIT_CURL_VERBOSE for compatibility - Documenting these GIT_TRACE_CURL_XXX variables (GIT_CURL_VERBOSE it is not even documented i think) - perhaps use the git trace api in doing these new patches Look reasonable? It seems reasonable? I'd like your own opinion Thank you for your suggestion > > I am not saying new GIT_*_DEBUG is wrong. I just wanted to make > sure you have considered doing this as a new trace in GIT_TRACE_* > family and rejected that apporach with a very good reason, in > which case that rationale deserves to be in the log message.