From: Hariom verma <hariom18599@gmail.com>
Date: Sat, 30 Jan 2021 19:16:56 GMT
Subject: Re: [PATCH v2 2/3] pretty.c: capture invalid trailer argument
Message-ID: <CA+CkUQ9sKyWJYahnZqfy1OfxxA+ukv148SCxjbGaOBzkCH0kbg@mail.gmail.com>
In-Reply-To: <CAP8UFD00sdiaFYUvgzQmXKCQSyrNKG82_xXvRGRaqdkbqKu7UQ@mail.gmail.com>

Hi Christian,

On Sat, Jan 30, 2021 at 3:58 AM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Fri, Jan 29, 2021 at 10:15 PM Hariom Verma via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> >
> > From: Hariom Verma <hariom18599@gmail.com>
> >
> > As we would like to use this same logic in ref-filter, it's nice to
> > get invalid trailer argument. This will allow us to print precise
> > error message, while using `format_set_trailers_options()` in
> > ref-filter.
>
> Thanks for continuing to work on this!
>
> >  {
> >         for (;;) {
> >                 const char *argval;
> >                 size_t arglen;
> >
> > +               if(**arg == ')') {
> > +                       break;
> > +               }
>
> A space char is missing between "if" and "(". Also no need for "{" and
> "}". It could just be:
>
> > +               if (**arg == ')')
> > +                       break;

Thanks for pointing this out. Will fix it.