From: Linus Torvalds Date: Sat, 14 Jul 2012 20:56:17 GMT Subject: Re: [PATCH maint-1.6.5 v2] block-sha1: avoid pointer conversion that violates alignment constraints Message-ID: In-Reply-To: <20120714205049.GA28502@burratino> Looks good to me. I'd suggest doing the macro argument expansion in #define SHA_SRC(t) get_be32((unsigned char *) block + t*4) with parenthesis around 't', but that's a fairly independent thing. The old code didn't do that either. Linus