From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 16 May 2017 20:27:42 GMT
Subject: Re: git rebase regression: cannot pass a shell expression directly to --exec
Message-ID: <CA+55aFwX2RDwT=g4w55bbLV38ggaVpdcLpMcCvqMcKRziUSesQ@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.21.1.1705162211320.3610@virtualbox>

On Tue, May 16, 2017 at 1:12 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>>
>> I think it would be better to just
>>
>>  (a) get rid of the magic strcspn() entirely
>>
>>  (b) make the 'can we optimize this' test be simply just looking up
>> 'argv[0]' in $PATH
>
> What about
>
>         ABC=1 my-executable my-arg

What about it?

Do you have a binary like

    '/usr/bin/ABC=1 my-executable my-arg'

or something? If so, it gets executed. If not, it would get passed off
to "/bin/sh".

That sounds a lot more obvious than "some random set of characters are magical".

                  Linus