From: adrian wijaya Date: Fri, 20 Mar 2020 15:45:53 GMT Subject: Re: [GSOC][PATCH 1/2] t1300: replace "test -f" into "test_path_is_file" Message-ID: In-Reply-To: <20200319234723.6504-1-adrianwijaya100@gmail.com> From 5fb689207ebe06b5f4c506b0b184c95a8a2e529d Mon Sep 17 00:00:00 2001 From: Adrian Wijaya Date: Thu, 19 Mar 2020 21:13:44 +0700 Subject: [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file" Convert "test -f" with "test_path_is_file" to give more verbose test output on failure. Signed-off-by: Adrian Wijaya --- t/t1300-config.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 97ebfe1f9d..d74554fc09 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1020,11 +1020,11 @@ test_expect_success SYMLINKS 'symlinked configuration' ' ln -s notyet myconfig && git config --file=myconfig test.frotz nitfol && test -h myconfig && - test -f notyet && + test_path_is_file notyet && test "z$(git config --file=notyet test.frotz)" = znitfol && git config --file=myconfig test.xyzzy rezrov && test -h myconfig && - test -f notyet && + test_path_is_file notyet && cat >expect <<-\EOF && nitfol rezrov -- 2.26.0.rc1.11.g30e9940356 On Fri, Mar 20, 2020 at 6:47 AM Adrian Wijaya wrote: > > Dear all, > > In this year, I intend to apply in git for GSoC 2020. This is actually my > first contribution to the git community. I am a sophomore Computer Science > student at University of Indonesia. > > In this patch, I have replaced 'test -f' into 'test_path_is_file' function > (can be found in test-lib-functions). > > Suggestions and advice are very welcome. > > Regards, > Adrian Wijaya