From: Wincent Colaiuta Date: Thu, 27 Mar 2008 08:34:00 GMT Subject: Re: [PATCH 0/2] add--interactive: better mode change handling Message-ID: In-Reply-To: <20080327072931.GA22444@coredump.intra.peff.net> El 27/3/2008, a las 8:29, Jeff King escribió: > There may potentially be a "[3/2] change the name of the 'p'atch > command" since it is now not just about the patch (actually, since git > patches _do_ include mode changes, it maybe is appropriate). Wincent > suggested "pick" which I think is reasonable. I'm not planning on > doing > such a 3/2, but I'm sure some industrious soul can make arguments > for or > against changing the name. I will let them handle the ensuing bikeshed > jamboree. I don't really want to participate in such a jamboree either, but I will add this one last comment that I should have mentioned in my previous email: one thing to bear in mind when considering changing the subcommand name is that "git add" itself has a "--patch" option since a couple of releases ago, and that means that changing the subcommand name either means introducing a mismatch between the option name and subcommand name, or going through a deprecate/rename cycle for the option name too, which we just introduced. I don't really care either way. My muscle memory is trained for "patch" at this point, but changing wouldn't be a problem either. In any case, your patches 1 and 2 look pretty sane to me. Cheers, Wincent