From: Alexander Rinass Date: Wed, 06 Apr 2016 06:51:28 GMT Subject: Re: [PATCH] diff: run arguments through precompose_argv Message-ID: In-Reply-To: <57040EE0.40503@kdbg.org> > On 05 Apr 2016, at 21:15, Johannes Sixt wrote: > > Am 05.04.2016 um 19:09 schrieb Junio C Hamano: >>> Thanks-to: Torsten Bögershausen > > I sense NFD disease: The combining diaresis should combine with the o, not the g. Here is a correct line to copy-and-paste if you like: > > Thanks-to: Torsten Bögershausen > > -- Hannes Thanks for reviewing and catching the NFD encoding error. I will send in a patch v2 with the correct NFC encoding. Would you also like me to alter the commit message as mentioned by Junio? I could rewrite the sentence: “As a result, no diff is displayed when feeding such a file path to the diff command.” into simply saying: “As a result, no diff is displayed.” However, I don't read the original message as it would imply that only file paths are affected by the precompose_argv call. Are there other suggestions on improving the commit message?