From: Lars Schneider <larsxschneider@gmail.com>
Date: Wed, 23 Sep 2015 07:38:39 GMT
Subject: Re: [PATCH v7 1/7] git-p4: add optional type specifier to gitConfig reader
Message-ID: <C363CF9F-0104-4874-9C88-F966CFD2EA77@gmail.com>
In-Reply-To: <xmqqd1xa15ws.fsf@gitster.mtv.corp.google.com>


On 22 Sep 2015, at 23:49, Junio C Hamano <gitster@pobox.com> wrote:

> larsxschneider@gmail.com writes:
> 
>> From: Lars Schneider <larsxschneider@gmail.com>
>> 
>> The functions “gitConfig” and “gitConfigBool” are almost identical. Make “gitConfig” more generic by adding an optional type specifier. Use the type specifier “—bool” with “gitConfig” to implement “gitConfigBool. This prepares the implementation of other type specifiers such as “—int”.
> 
> What is this overlong single line paragraph?  Is this a MUA artifact
> on my end?
> 
No. It looks like I messed that up. Same is true for the commit “git-p4: add gitConfigInt reader”. I’ll be more careful in the future.

Sorry,
Lars