From: Joel Holdsworth <jholdsworth@nvidia.com>
Date: Fri, 10 Dec 2021 10:41:49 GMT
Subject: RE: [PATCH 4/6] git-p4: Decode byte strings before printing
Message-ID: <BN8PR12MB3361A80F11E68CB4808D7423C8719@BN8PR12MB3361.namprd12.prod.outlook.com>
In-Reply-To: <xmqqczm5o0pa.fsf@gitster.g>

> Is the use of strings with {} placeholders and their .format() method integral
> part of "decoding byte strings before printing", or it is just a
> new/better/improved/subjectively-preferred/whatever style?
> 
> If the latter, such a change should be separated into its own step, or at least
> needs to be mentioned and justified in the proposed log message.

As I mentioned in my other message, I would like to invest some time into tidying and modernising the script - as well as fixing bugs and improving behaviour. If I submit patches that only make subjective style improvements, are these likely to be accepted?

> Lack of explanation on "why" is shared among all these patches, it seems, so I
> won't repeat, but the patches need to explain why to their readers.

Fair enough. I will resubmit.