From: Eric DeCosta <edecosta@mathworks.com>
Date: Mon, 12 Sep 2022 19:39:59 GMT
Subject: RE: [PATCH v5 0/4] fsmonitor: option to allow fsmonitor to run against network-mounted repos
Message-ID: <BL0PR05MB5571582512C460D95E1F1839D9449@BL0PR05MB5571.namprd05.prod.outlook.com>
In-Reply-To: <xmqqr10gcrjp.fsf@gitster.g>



> -----Original Message-----
> From: Junio C Hamano <jch2355@gmail.com> On Behalf Of Junio C Hamano
> Sent: Monday, September 12, 2022 3:38 PM
> To: Eric DeCosta via GitGitGadget <gitgitgadget@gmail.com>
> Cc: git@vger.kernel.org; Jeff Hostetler <git@jeffhostetler.com>; Eric Sunshine
> <sunshine@sunshineco.com>; Torsten Bögershausen <tboegi@web.de>;
> Ævar Arnfjörð Bjarmason <avarab@gmail.com>; Ramsay Jones
> <ramsay@ramsayjones.plus.com>; Johannes Schindelin
> <Johannes.Schindelin@gmx.de>; Eric DeCosta <edecosta@mathworks.com>
> Subject: Re: [PATCH v5 0/4] fsmonitor: option to allow fsmonitor to run
> against network-mounted repos
> 
> Junio C Hamano <gitster@pobox.com> writes:
> 
> >> Eric DeCosta (4):
> >>   fsmonitor: refactor filesystem checks to common interface
> >>   fsmonitor: relocate socket file if .git directory is remote
> >>   fsmonitor: avoid socket location check if using hook
> >>   fsmonitor: deal with synthetic firmlinks on macOS
> >
> > It looks like this one is organized quite differently from the last
> > iteration <pull.1326.v4.git.1661962145.gitgitgadget@gmail.com>
> 
> Given that we are very close to -rc period, I am very tempted to say that this
> follow-up effort can and should be separated out of the previous "windows
> only" one, and we should merge the single patch that has been in 'next' to
> 'master' without waiting for this "macOS, too" topic.  What do people think?
> 
> Thanks.

I'm totally fine with that, turned out to be a bit more involved than I initially anticipated.

-Eric