From: Eric DeCosta <edecosta@mathworks.com>
Date: Wed, 05 Oct 2022 21:14:15 GMT
Subject: RE: [PATCH v15 0/6] fsmonitor: option to allow fsmonitor to run against network-mounted repos
Message-ID: <BL0PR05MB557152E4728FBF3DB4B27CFAD95D9@BL0PR05MB5571.namprd05.prod.outlook.com>
In-Reply-To: <xmqq35c2qh7u.fsf@gitster.g>



> -----Original Message-----
> From: Junio C Hamano <jch2355@gmail.com> On Behalf Of Junio C Hamano
> Sent: Wednesday, October 5, 2022 2:05 PM
> To: Eric DeCosta via GitGitGadget <gitgitgadget@gmail.com>
> Cc: git@vger.kernel.org; Jeff Hostetler <git@jeffhostetler.com>; Eric Sunshine
> <sunshine@sunshineco.com>; Torsten Bögershausen <tboegi@web.de>;
> Ævar Arnfjörð Bjarmason <avarab@gmail.com>; Ramsay Jones
> <ramsay@ramsayjones.plus.com>; Johannes Schindelin
> <Johannes.Schindelin@gmx.de>; Eric DeCosta <edecosta@mathworks.com>
> Subject: Re: [PATCH v15 0/6] fsmonitor: option to allow fsmonitor to run
> against network-mounted repos
> 
> "Eric DeCosta via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > An additional issue is that for mount points in the root directory,
> > FSEvents does not report a path that matches the worktree directory
> > due to the introduction of 'synthetic firmlinks'. fsmonitor must map
> > the FSEvents paths to the worktree directory by interrogating the root
> > filesystem for synthetic firmlinks and using that information to translate the
> path.
> >
> > v15 differs from v14:
> >
> >  * fix memory leak
> 
> Thanks.  I thought "what, another iteration?  didn't we see this enough times
> already?" and a note like this does help reminding reviewers why we need
> one.
> 
> Very much appreciated.

Thanks.  Just getting better at doing the right thing as I climb up the learning curve :)

Hopefully it is in a state where it is now GTM.

-Eric