From: sean <seanlkml@sympatico.ca>
Date: Fri, 13 Jan 2006 17:54:04 GMT
Subject: Re: git-commit: allow From: line to be entered in commit message
Message-ID: <BAYC1-PASMTP0918AE856AD34E35597CA4AE260@CEZ.ICE>
In-Reply-To: <7v64oo9gc7.fsf@assigned-by-dhcp.cox.net>

On Fri, 13 Jan 2006 09:40:24 -0800
Junio C Hamano <junkio@cox.net> wrote:

> Have you two known that more than one environment variables can
> be set for one-shot command execution?
> 
> 	$ GIT_AUTHOR_NAME="$author" \
> 	  GIT_AUTHOR_EMAIL="$email" git commit -F .msgfile
> 
> would give these environment variables for this "git commit"
> without affecting the later commands.

No, I didn't know that; thanks for the lesson.

> 
> Not that this really matters, since the above example was an
> excerpt of my suggestion about how to do this in a script,
> somehow made to look as if it was a suggestion about running
> things by hand from the command line...
> 

I said quite a few times now this has nothing to do with running
git-commit from a script.   This is just a simple request
to not require the use of environment variables to pass useful
parameters.

I really don't understand your gripe on this one, when someone 
else suggested using a command line parameter for author
information you said:

<quote>

> 	--from="Some User <some.user@theoffice.org>"
>

I agree this would be more useful, direct, easy to understand
and explain way to do it.

</quote>


So do you still agree with that, would you accept a patch?  Or do you have
some fundamental reason to think that environment variables are a better
way to pass information in this case?

Cheers,
Sean