From: sean Date: Fri, 13 Jan 2006 04:06:33 GMT Subject: Re: git-commit: allow From: line to be entered in commit message Message-ID: In-Reply-To: <7v4q48hizr.fsf@assigned-by-dhcp.cox.net> On Thu, 12 Jan 2006 20:03:36 -0800 Junio C Hamano wrote: > sean writes: > > > ... Apparently he is more or less > > hand munging mutliple cvs branches into a nice git package for > > Linus to pull. He said that many of the patches don't apply as-is > > and need some manual tweaking before committing. > > Then what is needed is an exporter from those cvs branches into > git. Well, don't we have one already? If it does not work for > dirty changes, wouldn't it be better to fix it so it is > restartable, just like when rebase stops it lets you fix up and > go on, without having you to write "From: " or GIT_AUTHOR_* > yourself and just does the right thing? > Yes perhaps there is some streamlining of the cvs importer that could be done. However, I got the impression from him that he was cherry picking stuff out of multiple cvs branches so perhaps that's beyond what the cvs importer was ever designed to handle. Anyway, I think this is a more general problem than just the cvs importing case; the current interface for setting author information is brain damaged and a better method should be offered. I think you're over estimating the downsides of allowing this to be set the same was as it is in the git-am case and underestimating the number of people who would find it useful, but I personally don't really care if you'd rather have it as a command line option. Cheers, Sean