From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Thu, 09 Jun 2011 08:28:20 GMT
Subject: Re: [PATCH 17/19] transport-helper: export is no longer always the last command
Message-ID: <BANLkTinuZAJtuGw4hOLLjqLx5pN9iDhh+w@mail.gmail.com>
In-Reply-To: <20110609075141.GA4885@elie>

Heya,

On Thu, Jun 9, 2011 at 09:51, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Yes, but I'm still missing something.  What does the trailing \n ever
> have to be written?
>
> "git log -Sdisconnect_helper -- transport-helper.c" doesn't give many
> clues.  I imagine it's a way to check whether the child is still alive
> and to warn it not to be alarmed when the output end of its input pipe
> closes.

Yes, the trailing \n is to signal to the helper that the connection is
about to close, allowing it to do whatever cleanup necessarily. It's
kind of like the "done" command for fast-import.

-- 
Cheers,

Sverre Rabbelier