From: Nguyen Thai Ngoc Duy Date: Thu, 07 Apr 2011 13:09:43 GMT Subject: Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support Message-ID: In-Reply-To: <7v62qqhm9h.fsf@alter.siamese.dyndns.org> 2011/4/7 Junio C Hamano : > +                       if (('a' <= ch && ch <= 'z') || > +                           ('A' <= ch && ch <= 'Z')) { > +                               strbuf_addf(&sb, "[%c%c]", > +                                           tolower(ch), toupper(ch)); Nice try. You know you are going to pay a high performance price for that, don't you ;) Maybe also worth mentioning in document that this applies to ASCII charset only (as opposed to Unicode). -- Duy