From: Jérémie NIKAES <jeremie.nikaes@ensimag.imag.fr>
Date: Thu, 09 Jun 2011 14:30:45 GMT
Subject: Re: [PATCHv3 1/2] Add a remote helper to interact with mediawiki, pull & clone handled
Message-ID: <BANLkTinduWxp5QR+Ri3REoqVY3hYPc_-rg@mail.gmail.com>
In-Reply-To: <BANLkTikp6bGwVZqq7XAZ1bKVaMVLJ9XQiw@mail.gmail.com>

2011/6/9 Sverre Rabbelier <srabbelier@gmail.com>:
> Heya,
>
> On Thu, Jun 9, 2011 at 15:15, Jeremie Nikaes
> <jeremie.nikaes@ensimag.imag.fr> wrote:
>> +sub mw_capabilities {
>> +       print STDOUT "push\n";
>
>> +sub mw_push {
>> +       print STDERR "Push not yet implemented\n";
>> +}
>
> If it's not supported then you shouldn't advertise it above. Is there
> any particular reason you implemented it this way? E.g., did you
> encounter a breakage in remote-helpers if push is not implemented?

Well, if you dont give the capability to push, you get the following message

error: failed to push some refs to 'mediawiki::http://mediawikiurl'

Which is less explicit than 'Push not yet implemented'.


Regards,
-- 
Jérémie Nikaes