From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 12 Apr 2011 07:44:58 GMT
Subject: Re: [PATCH/RFC 1/7] i18n: mark init-db messages for translation
Message-ID: <BANLkTincUmH7SjypXfDMXDfg8BxW4MW+Jg@mail.gmail.com>
In-Reply-To: <7vy63gq6s2.fsf@alter.siamese.dyndns.org>

On Tue, Apr 12, 2011 at 09:15, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>>      fp = fopen(git_link, "w");
>>>      if (!fp)
>>> -            die("Could not create git link %s", git_link);
>>> -    fprintf(fp, "gitdir: %s\n", git_dir);
>>> +            die(_("Could not create git link %s"), git_link);
>>> +    fprintf(fp, _("gitdir: %s\n"), git_dir);
>>>      fclose(fp);
>>> ...
>> I don't think this is correct.  The file "git_link" refers to .git that is
>> not a directory but is a regular file whose contents is "gitdir: $path"
>> and that should _never_ be localized, so the patch to die() message is Ok,
>> but the string given to fprintf(fp, ...) is _not_.
>
> See read_gitfile_gently() in setup.c; that is the reader of the
> information contained in this file.

Ah, thanks. Missed that. I'd have spotted it if I dug down instead of sending.

I'll re-send one without the translation for this plumbing message.