From: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Date: Sun, 10 Apr 2011 18:03:34 GMT
Subject: Re: [PATCH 1/8] gitk: fix file highlight when run in subdirectory
Message-ID: <BANLkTinZCCMQbQBF-j3bq3Wfxm2YRksCYQ@mail.gmail.com>
In-Reply-To: <20110410015410.GA25368@brick.ozlabs.ibm.com>

Hi Paul,

Thanks for your input. I will work on a re-roll of this series based
on, at least,
your input on patch 8/8. However, I am going away for 4 weeks today and I will
probably not be able to do that until some time after I come back. If
anyone else
cares to do it before then, please go ahead.

On Sat, Apr 9, 2011 at 9:54 PM, Paul Mackerras <paulus@samba.org> wrote:
> I have to admit I wasn't aware of GIT_WORK_TREE before I saw your
> patches.  The patches look OK, but I wonder how many of the problems
> would go away if gitk were simply to set GIT_WORK_TREE in the
> environment for the programs it runs, if it is not already set.

Most of the problems I have tried to fix in this series only appear when
GIT_WORK_TREE _is_ set, so I don't think setting it would help. When
it it not set,
setting it to the directory that git detected should have no effect as
far as I can see.


/Martin