From: Ævar Arnfjörð Bjarmason Date: Sun, 08 May 2011 21:52:01 GMT Subject: Re: [PATCH 0/4] i18n: Add shell script translation infrastructure Message-ID: In-Reply-To: On Sun, May 8, 2011 at 23:45, Sverre Rabbelier wrote: > Heya, > > [+msysgit people] > > On Sun, May 8, 2011 at 23:38, Ævar Arnfjörð Bjarmason wrote: >> On Sun, May 8, 2011 at 19:03, Sverre Rabbelier wrote: >>> On Sun, May 8, 2011 at 14:10, Ævar Arnfjörð Bjarmason wrote: >>>> This adds skeleton no-op functions to git-sh-i18n.sh analogous to the >>>> gettext.c skeleton functions for C, adds *.sh scripts to the "pot" >>>> target for message extraction, and updates the git-sh-i18n--envsubst >>>> tests to use the new test_i18ncmp function. >>> >>> I seem to remember there were some concerns about performance with a >>> previous version of this series. Have you done any before/after >>> timings on, say, the git test suite? Or am I remembering incorrectly? >> >> When I benchmark this on my (Linux) system it runs at 0% difference >> between the current test suite and the one with this series. >> >> The concern was about Windows, where forks are more expensive, so >> e.g. every time we shell out to sed/awk/perl/grep or >> git-sh-i18n--envsubst we incur a larger speed hit than on Unix >> systems. > > Perhaps one of the windows devs can benchmark this then? Ævar, where > do you have a pullable version of this series? Your github fork has > quite a few branches. It's ab/i18n-sh-only in git://github.com/avar/git.git There was some discussion about this a while ago, not sure what came out of that, but there were some msysgit patches involved IIRC.