From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Wed, 15 Jun 2011 07:26:03 GMT
Subject: Re: Test 9500 - unhelpful without Perl::CGI
Message-ID: <BANLkTinAfqysABm+t_NkOGO2U+iy57WbVQ@mail.gmail.com>
In-Reply-To: <7vmxhjk539.fsf@alter.siamese.dyndns.org>

Heya,

On Wed, Jun 15, 2011 at 07:59, Junio C Hamano <gitster@pobox.com> wrote:
> +perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || {
> +       skip_all='skipping gitweb tests, CGI module unusable'
> +       test_done
> +}
> +

Isn't the new style to use test_must_succeed CGI_AVAILABLE '...' '...'
rather than skip_all+test_done?

-- 
Cheers,

Sverre Rabbelier