From: David Barr <davidbarr@google.com>
Date: Fri, 24 Jun 2011 14:39:42 GMT
Subject: Re: [RFC/PATCH 1/3] protobuf: minimal implementation for compact in-memory structures
Message-ID: <BANLkTimov2ZFYZjU4=CXPE8yjH8cMs3HCg@mail.gmail.com>
In-Reply-To: <7voc1p64ap.fsf@alter.siamese.dyndns.org>

Junio,

Sorry for the repeat, accidentally sent as HTML, rejected by the list.

On Thursday, June 23, 2011, Junio C Hamano wrote:
David Barr <davidbarr@google.com> writes:

> One struct to capture all types, just 4 methods: decode_message,
> encode_message, sizeof_message, hash_field.

Adding to the review from yesterday, hash_field() looked quite out of
place. If you are going to implement a hash table that holds protobuf
objects in a separate file/module, I would imagine the function belongs
there, not here.

I agree completely, another artifact of refactoring from experimental code.

--
David Barr