From: Thiago Farina <tfransosi@gmail.com>
Date: Wed, 06 Apr 2011 02:46:19 GMT
Subject: Re: [PATCH v2 1/3] blame: add --abbrev command line option
Message-ID: <BANLkTim8bR1Z5sQCtVeqCJcCh_wuQxCvJQ@mail.gmail.com>
In-Reply-To: <1302056452-5387-1-git-send-email-namhyung@gmail.com>

On Tue, Apr 5, 2011 at 11:20 PM, Namhyung Kim <namhyung@gmail.com> wrote:
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
>  builtin/blame.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/builtin/blame.c b/builtin/blame.c
> index f6b03f7..253b480 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -41,6 +41,7 @@ static int reverse;
>  static int blank_boundary;
>  static int incremental;
>  static int xdl_opts;
> +static int abbrev = 8;
>
>  static enum date_mode blame_date_mode = DATE_ISO8601;
>  static size_t blame_date_width;
> @@ -1670,7 +1671,7 @@ static void emit_other(struct scoreboard *sb, struct blame_entry *ent, int opt)
>        cp = nth_line(sb, ent->lno);
>        for (cnt = 0; cnt < ent->num_lines; cnt++) {
>                char ch;
> -               int length = (opt & OUTPUT_LONG_OBJECT_NAME) ? 40 : 8;
> +               int length = (opt & OUTPUT_LONG_OBJECT_NAME) ? 40 : abbrev;

Should this 40 be a constant?