From: Sverre Rabbelier Date: Wed, 08 Jun 2011 20:07:07 GMT Subject: Re: [PATCH 10/19] fast-import: introduce 'done' command Message-ID: In-Reply-To: <20110608200345.GJ27715@elie> Heya, On Wed, Jun 8, 2011 at 22:03, Jonathan Nieder wrote: >  C) make sure the upstream of the pipe does not write anything after >    "done\n" until the "done\n" command has been read.  In other >    words: > >        transport-helper>       done >        remote-helper>          yep, I'm done >        transport-helper>       ah, now that you mention that, here are >                                a few more things you could do... > > As long as there is nothing after the "done\n" in the pipe buffer when > fast-import reads "done\n", it won't read too far. This I think makes the most sense. Although I'm not sure it's currently possible in remote-testgit, as in, I'm not sure the relevant pipes are connected to the right programs to make feasible. Also, I'm not really interested in implementing that, or at least, not right now, I just shamelessly stole your commit message ;). -- Cheers, Sverre Rabbelier