From: Avery Pennarun <apenwarr@gmail.com>
Date: Thu, 05 May 2011 17:59:36 GMT
Subject: Re: t5541: Bad file descriptor
Message-ID: <BANLkTi=y+34s+yO9LVuiUxB5Xz3v7Pc2Mw@mail.gmail.com>
In-Reply-To: <BANLkTin8YUwoMmxXLske=5nuvW+idBOuig@mail.gmail.com>

On Thu, May 5, 2011 at 7:18 AM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> On Thu, May 5, 2011 at 08:16, Jeff King <peff@peff.net> wrote:
>> OK, embarrassing. 09c9957 completely breaks smart http pushing. My
>> testing of Johannes' patch was completely focused on the error case, and
>> I didn't have a single test for the non-error case. And on top of that,
>> we _have_ nice tests in the test suite to catch this, but obviously
>> neither I, nor Johannes, nor Junio were running them (because they need
>> apache installed and GIT_TEST_HTTPD set).
>
> Wasn't someone, I _think_ Ævar, or maybe Avery, (I could be totally
> wrong) running a buildbot of git.git on various platforms? If so,
> maybe they can turn on these tests since they aren't often run?

I was running one, didn't think anybody cared about it though.  Please
point me at the necessary docs for this test and I can set up a new
one in my copious spare time (tm).  I can't promise to monitor it
though, so that might be more of a problem :)  gitbuilder does produce
rss feeds that are easy to track.

Have fun,

Avery