From: Jay Soffian <jaysoffian@gmail.com>
Date: Sat, 14 May 2011 22:22:38 GMT
Subject: Re: [PATCH v2] Add log.abbrevCommit config variable
Message-ID: <BANLkTi=og+e6JW8t+sCvkFJUnR=SrFtWGg@mail.gmail.com>
In-Reply-To: <20110514215543.GA23648@elie>

On Sat, May 14, 2011 at 5:55 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Jay Soffian wrote:
>
>> Add log.abbrevCommit config variable as a convenience for users who
>> often use --abbrev-commit with git log and friends. Allow the option
>> to be overridden with --no-abbrev-commit.
>
> Based on a quick google code search, this will break scripts. :/
> For example, tig uses "git log --pretty=raw" to get revision lists,
> including expecting 40-digit commit ids.

Hmfph.

> But aside from that, this looks good to me.  I'm not sure what to
> suggest: go out and spread the word about diff-tree? suppress this
> configuration when --pretty or --format is passed?  There's no obvious
> good answer.

Ah, see:

- 635530a2fc (log --pretty/--oneline: ignore log.decorate, 2010-04-06)
- 4f62c2bc57 (log.decorate: only ignore it under "log --pretty=raw", 2010-04-08)

So I'll do the same thing for log.abbrevCommit.

j.