From: Shawn Pearce <spearce@spearce.org>
Date: Fri, 01 Jul 2011 17:18:15 GMT
Subject: Re: [Wishlist] could git tell which password it is asking when asking a password.
Message-ID: <BANLkTi=aAinh=0jxb5MoqVOdUB7zxoy2XdSqk+pdsewLXU62ZA@mail.gmail.com>
In-Reply-To: <7v1uy9q5v1.fsf@alter.siamese.dyndns.org>

On Fri, Jul 1, 2011 at 10:16, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> diff --git a/http.c b/http.c
> index b2ae8de..44948a7 100644
> --- a/http.c
> +++ b/http.c
> @@ -209,8 +209,11 @@ static void init_curl_http_auth(CURL *result)
>  {
>        if (user_name) {
>                struct strbuf up = STRBUF_INIT;
> -               if (!user_pass)
> -                       user_pass = xstrdup(git_getpass("Password: "));
> +               if (!user_pass) {
> +                       strbuf_addf(&up, "Password for %s: ", user_name);

The user_name by itself may not be sufficient. I may also need the URL
to correctly answer the question. I don't always use the same password
on every website. :-)

As a human sure, I know what URL I asked Git to poke for me. But if I
want to write a script that looks this up in a password manager for
me, that script needs the URL.

Food for thought.

-- 
Shawn.