From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 13 May 2011 09:48:25 GMT
Subject: Re: [PATCH 20/48] i18n: git-submodule die + eval_gettext messages
Message-ID: <BANLkTi=QvxfUfmdYv8tmYpfHXWpaKOcFnQ@mail.gmail.com>
In-Reply-To: <BANLkTim0VZ6-xbgZC0K=HXfVMaWehJ0pBA@mail.gmail.com>

On Fri, May 13, 2011 at 11:04, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> On Fri, May 13, 2011 at 10:21 AM, Ævar Arnfjörð Bjarmason
>> That's interesting. I thought that the problem would only be with
>> PATH, since we'd clobber the other environment variables when we do
>> the export in git-sh-i18n.
>>
>> But evidently not, but I don't quite grok why.
>>
>> Anyway, this behavior seems un-POSIX compliant, and I'd been assuming
>> that our shell scripts were POSIX shellscripts when I wrote this.
>
> May I remind you of the first rule in Documentation/CodingGuidelines?
>
>  - Most importantly, we never say "It's in POSIX; we'll happily
>   ignore your needs should your system not conform to it."
>   We live in the real world.

I'm not saying we shouldn't work around it, I'll submit another series
which adds some unique prefix to all the environment variables.

I was just saying that I'd assumed that at least POSIX behavior for
environment variables could be relied upon.