From: Shawn Pearce <spearce@spearce.org>
Date: Fri, 03 Jun 2011 00:01:19 GMT
Subject: Re: [PATCH/RFC] http: pass http.cookiefile using CURLOPT_COOKIEFILE
Message-ID: <BANLkTi=3cQx9L4rrkniBhqFfL1TuNgu0doaSpdV8ajgsWJvw1Q@mail.gmail.com>
In-Reply-To: <20110602203125.0E04C734F12@antares.phy.syr.edu>

On Thu, Jun 2, 2011 at 13:31, Duncan Brown <dabrown@physics.syr.edu> wrote:
> If the config option http.cookiefile is set, pass this file to libCURL using
> the CURLOPT_COOKIEFILE option. This is similar to calling curl with the -b
> option.  This allows git http authorization with authentication mechanisms
> that use cookies, such as SAML Enhanced Client or Proxy (ECP) used by
> Shibboleth.

Wow, the patch was this simple?

Thanks Duncan!

> ---
>  Documentation/config.txt |    8 ++++++++
>  http.c                   |    5 +++++
>  2 files changed, 13 insertions(+), 0 deletions(-)

Junio, I didn't test this myself, but the code looks good to me. I
don't see any obvious issues with it.

-- 
Shawn.