From: Philip Oakley Date: Tue, 21 Jul 2015 20:39:03 GMT Subject: Re: [PATCH v2b 00/16, 2 updates] Make the msvc-build scripts work again Message-ID: In-Reply-To: From: "Junio C Hamano" > Junio C Hamano writes: > >> "Philip Oakley" writes: >> >>> ... Ideally, if part of this >>> mainstream Git, it would get picked up automatically by them >>> (rather than being local 'fixes' endlessly carried forward). >> >> Actually, that is not "ideal", but what I want to avoid. >> >> As I do not do Windows, it simply is wrong for me to apply changes >> that are very likely to affect Windows folks without seeing their >> support first,... > > Just to clarify this part. I do not do RedHat, Solaris or OSX, > either. Also MSVC may not be what GfW folks primarily target. > > But the thing is that (1) Windows is so much different, and (2) GfW > folks are much more qualified to judge platform-specific issues on > Windows than I am. > > Even though I may still need to have a say in the overall structure > of the changes to the upstream tree coming from them (e.g. "Don't > sprinkle #ifdef all over the generic code; instead add a wrapper or > two in compat/ to keep the generic code generic" is something I may > tell them when rejecting a change forwarded to me), I trust them a > lot more than I trust myself when it comes to what the changes do in > the platform-specific part and how they do it. > > Thanks. > -- Thanks for the extra clarification. I'll ask if they can confirm this update on GfW. I've also asked Ramsay what his current situation is re- you previous email and the msvc-build. regards Philip