From: Steffen Prohaska Date: Fri, 10 Aug 2007 07:03:15 GMT Subject: Re: msysgit: does git gui work? Message-ID: In-Reply-To: <20070810053158.GJ24573@spearce.org> On Aug 10, 2007, at 7:31 AM, Shawn O. Pearce wrote: > Steffen Prohaska wrote: >> mingw only contains tclsh84 but not tclsh. This causes >> the Makefile in git-gui to fail on the creation of >> lib/tclIndex. Therefore git gui decides to take the slow >> path of sourcing the files in lib explicitly but this failes >> because they are sourced before git-version is defined. >> Therefore blame.tcl reports the error mentioned above. >> >> Johannes (or someone else from the msysgit team), >> We should modify mingw to contain the symlink to tclsh. >> Or something similar, at least 'tclsh' should be there. >> >> Shawn, >> The fallback mechanism of sourcing files from lib is broken. >> Either git-version must be defined before sourcing them, or >> the auto_index must always work. > > *ouch*. Yea, that happened when the git-version proc was introduced. > It doesn't get declared until after we have sourced everything, > but the things we are sourcing want it to be declared. > > The short-term workaround is the obvious thing of just making > sure the auto_index works in the Makefile. I'll try to reorder > things in git-gui so that the "source everything fallback" is > done only after git-version is declared. Though that might be > difficult as that codepath assumes error_popup has been declared > and that's in something we are sourcing. Marius, Johannes, I really think the right way to fix this would be to include tclsh.exe in mingw. I tried to push a commit to mob but failed to do so (see separate mail on submodule to the list). btw, I recognized that '.' is included in the PATH in /etc/profile. I don't think this is a good idea. At least it bit me once when I expected to run /bin/git but instead /git/./git was chosen. Shouldn't we remove '.' from the PATH? Steffen