From: Lidong Yan <yldhome2d2@gmail.com>
Date: Mon, 11 Aug 2025 16:08:03 GMT
Subject: Re: [PATCH v5] bloom: enable bloom filter with wildcard pathspec in revision traversal
Message-ID: <B5A8897E-3D20-487D-9774-444463F81DA4@gmail.com>
In-Reply-To: <xmqqy0rp3l8s.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:
> 
> Lidong Yan <yldhome2d2@gmail.com> writes:
> 
>> Signed-off-by: Lidong Yan <yldhome2d2@gmail.com>
>> [jc: avoid allocating zero length path in
>> convert_pathspec_to_bloom_keyvec()]
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> 
> Instead just do
> 
>        Helped-by: Junio C Hamano <gitster@pobox.com>
>        Signed-off-by: Lidong Yan <yldhome2d2@gmail.com>
> 
> here.  [who: comment] followed by a sign-off from that person is
> done by the person who is signing off the tweak, not by the original
> author.

I see — when someone makes additions to another person’s
commit, they’ll also modify the log message in the process.

Thanks,
Lidong