From: Steffen Prohaska <prohaska@zib.de>
Date: Mon, 19 Aug 2013 08:28:02 GMT
Subject: Re: [PATCH v2] compat: Fix read() of 2GB and more on Mac OS X
Message-ID: <B58CB9DC-029F-4568-8A27-0C60FFA6766B@zib.de>
In-Reply-To: <5211D544.8080706@kdbg.org>


On Aug 19, 2013, at 10:20 AM, Johannes Sixt <j6t@kdbg.org> wrote:

> Am 19.08.2013 08:38, schrieb Steffen Prohaska:
>> +test_expect_success EXPENSIVE 'filter large file' '
>> +	git config filter.largefile.smudge cat &&
>> +	git config filter.largefile.clean cat &&
>> +	for i in $(test_seq 1 2048); do printf "%1048576d" 1; done >2GB &&
> 
> Shouldn't you count to 2049 to get a file that is over 2GB?

No.  INT_MAX = 2GB - 1 works.  INT_MAX + 1 = 2GB fails.  It tests exactly at the boundary.

	Steffen