From: Jonathan del Strother <maillist@steelskies.com>
Date: Wed, 17 Oct 2007 09:14:01 GMT
Subject: Re: [PATCH 1/3] Fixing path quoting in git-rebase
Message-ID: <B495731E-C854-450B-943B-B96248B8F609@steelskies.com>
In-Reply-To: <47136D92.8060104@viscovery.net>

On 15 Oct 2007, at 14:39, Johannes Sixt wrote:

> Jonathan del Strother schrieb:
>> -	eval GITHEAD_$hd='"$(cat $dotest/onto_name)"'
>> +	eval GITHEAD_$hd='"$(cat \"$dotest/onto_name\")"'
>
> I believe this is not correct. It should be this way:
>
> 	eval GITHEAD_$hd='$(cat "$dotest/onto_name")'
>
> You can test it with a conflicting git-rebase -m. It only affects  
> what the conflict markers look like. The test suite does not test it.

Thanks for catching that.  I'll post revised patches this morning