From: Romain Geissler Date: Mon, 30 May 2011 16:10:20 GMT Subject: Re: Git global usage and tests Message-ID: In-Reply-To: <20110530153620.GA24431@sigill.intra.peff.net> Le 30 mai 2011 à 17:36, Jeff King a écrit : > Your option parser needs to follow these rules to be compatible with > git. Sure, according to our mentor teacher (Matthieu Moy) parse-option can handle both if the command is followed by a required argument, we just need to specify it. > Have you considered pulling the parse-options parser from git into > libgit2? It's one of the more modularized and lib-ified bits of code in > git already. Yes and No. We have already copied some code from git : parse-option, the error handling functions, a part of the run-command block and a part of the compatibility layer. To my mind, there is no reason to pull it into libgit2 as it's only a client feature that works on strings, and libgit2 does not aim at being a client, only a git library. Romain Geissler