From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Sat, 25 Sep 2010 04:45:42 GMT
Subject: Re: [PATCH v1] stash show: fix breakage in 1.7.3
Message-ID: <AF7816CF-7515-4386-9736-417005434433@gernhardtsoftware.com>
In-Reply-To: <1285385521-17012-1-git-send-email-jon.seymour@gmail.com>


On Sep 24, 2010, at 11:32 PM, Jon Seymour wrote:

> due to a faulty assumption that:
>   git rev-parse --no-revs -- stash@{0}

This assumption is faulty, it should be "git rev-parse --no-revs --flags stash@{0}", which works properly for all revision arguments and flags _except_ -q and --quiet.

> This revision further simplifies the parsing code
> by removing use of git rev-parse for FLAGS parsing
> altogether.

That is simpler, and does fix this specific issue.  However, I would strongly argue that "git rev-parse --no-revs --flags" is broken.  I really don't have the time tonight or probably this weekend to work on it, but git-rev-parse should only take "-q" and "--quiet" for itself if "--verify" was passed.  (Since that is the only mode in which rev-parse uses quiet, AFAIK.)

Possibly rev-parse should also (or instead) separate "arguments for rev-parse" and "arguments rev-parse is parsing" using the standard "--".  I don't know if this will affect any current users.

~~ Brian