From: Lars Schneider <larsxschneider@gmail.com>
Date: Wed, 11 Jan 2017 09:51:32 GMT
Subject: Re: [PATCH v1] convert: add "status=delayed" to filter process protocol
Message-ID: <AE35779E-5FE3-4F50-A168-C7316A146C09@gmail.com>
In-Reply-To: <20170108204517.GA13779@starla>


> On 08 Jan 2017, at 21:45, Eric Wong <e@80x24.org> wrote:
> 
> larsxschneider@gmail.com wrote:
>> +++ b/t/t0021/rot13-filter.pl
> 
>> +$DELAY{'test-delay1.r'} = 1;
>> +$DELAY{'test-delay3.r'} = 3;
>> 
>> open my $debug, ">>", "rot13-filter.log" or die "cannot open log file: $!";
>> 
>> @@ -166,6 +176,15 @@ while (1) {
>> 		packet_txt_write("status=abort");
>> 		packet_flush();
>> 	}
>> +	elsif ( $command eq "smudge" and
>> +		    exists $DELAY{$pathname} and
>> +		    $DELAY{$pathname} gt 0 ) {
> 
> Use '>' for numeric comparisons.  'gt' is for strings (man perlop)

Still learning Perl :-)


> Sidenote, staying <= 80 columns for the rest of the changes is
> strongly preferred, some of us need giant fonts.  I think what
> Torsten said about introducing a new *_internal function can
> also help with that.

OK! 

Thank you,
Lars