From: Wincent Colaiuta <win@wincent.com>
Date: Wed, 05 Dec 2007 16:31:23 GMT
Subject: Re: [PATCH/RFC] autoconf: Add test for OLD_ICONV
Message-ID: <ADB12552-AD67-4781-B194-AD15CA4A7B44@wincent.com>
In-Reply-To: <1196869526-2197-1-git-send-email-jnareb@gmail.com>

El 5/12/2007, a las 16:45, Jakub Narebski escribió:

> Update configure.ac (and config.mak.in) to keep up with git
> development by adding [compile] test whether your library has
> an old iconv(), where the second (input buffer pointer) parameter
> is declared with type (const char **) (OLD_ICONV).
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> This patch needs checking if it correctly sets OLD_ICONV
> when needed.  I have checked only that it is not set when
> with new iconv() declaration.  Could people using Cygwin
> (and other with OLD_ICONV: Darwin) test it?

Before applying your patch:

     CC utf8.o
utf8.c: In function ‘reencode_string’:
utf8.c:328: warning: passing argument 2 of ‘iconv’ from incompatible  
pointer type
     CC convert.o

After applying your patch:

     CC utf8.o
     CC convert.o

This on Darwin Kernel Version 9.1.0 (Mac OS X 10.5.1).

Cheers,
Wincent