From: Andy Lester Date: Wed, 22 Apr 2009 19:13:28 GMT Subject: Re: Removing duplicated code between builtin-send-pack.c and transport.c Message-ID: In-Reply-To: <20090422191044.GC13424@coredump.intra.peff.net> On Apr 22, 2009, at 2:10 PM, Jeff King wrote: > I don't know if that is quite appropriate. I think the point of moving > many of the duplicated functions into transport.c is that they are > used > by other transports, like http. So probably the transport-agnostic > ones > should stay in transport.c, and they should all get called in the same > way, no matter what the transport. My mistake. I'll remove the code from builtin-send-pack.c, improve it, and builtin-send-pack.c can get deprecated when/if anyone wants. -- Andy Lester => andy@petdance.com => www.theworkinggeek.com => AIM:petdance